[v5] System for all actor logic #4055
Conversation
🦋 Changeset detectedLatest commit: 9268ef1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9268ef1:
|
| @@ -131,7 +146,12 @@ export function fromObservable<T, TEvent extends EventObject>( | |||
| */ | |||
|
|
|||
| export function fromEventObservable<T extends EventObject>( | |||
| lazyObservable: ({ input }: { input: any }) => Subscribable<T> | |||
| lazyObservable: ({ | |||
| input | |||
There was a problem hiding this comment.
It seems that input and/or system is defined as arguments differently across the fromFunctions. We only need the types right?
If that's the case wdyt about adding a shared interface for the types, something like this:
// Terrible name, please help 😅
interface FromRuntime {
input: any;
system: AnyActorSystem;
}
export function fromPromise<T>(
// Leaving out the arguments as we don't use them
promiseCreator: ({}: FromRuntime) => PromiseLike<T>
)...There was a problem hiding this comment.
Will do this in a follow-up PR, good idea
This PR provides access to
systemfor all actor logic.